[Klaud Cold] Update dsr1-fp8-h200-sglang SGLang image to v0.5.19-cu130 / 将 dsr1-fp8-h200-sglang 的 SGLang 镜像更新至 v0.5.19-cu130 - #3010
Conversation
Update the dsr1-fp8-h200-sglang master image from lmsysorg/sglang:v0.5.12-cu130 to lmsysorg/sglang:v0.5.19-cu130. Model, TP8 topology, 8k1k workload, concurrency grid, launch flags and evals are unchanged. 将 dsr1-fp8-h200-sglang 的主配置镜像从 lmsysorg/sglang:v0.5.12-cu130 更新至 lmsysorg/sglang:v0.5.19-cu130。模型、TP8 拓扑、8k1k 工作负载、并发网格、 启动参数与评测保持不变。 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
Initial attempt
初始尝试
|
Sync with main so the perf-changelog.yaml tail entry for PR #3010 applies on top of the entries merged since the candidate base; the image bump and changelog entry are unchanged. 与 main 同步,使 PR #3010 的 perf-changelog.yaml 尾部条目位于此后合并的条目 之上;镜像更新与 changelog 条目本身不变。 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Final full sweep
最终完整 sweep
|
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34600160889 |
|
Klaud Cold: validated. All owned runs are terminal. Repairs: 0. Runs: 34592860782, 34600160889. The full sweep is verified; this PR remains ready for review. Klaud Cold:validated。所有自有运行均已结束。修复次数:0。运行:34592860782, 34600160889。 完整 sweep 已通过验证;PR 保持就绪,等待审查。 |
|
Claude finished @Klaud-Cold's task in 1m 18s —— View job Review of PR #3010
LGTM - no blocking issues found. The diff against Note: the local |
There was a problem hiding this comment.
Looks good, straightforward image-version bump with matching changelog entry.
What was reviewed: the image field bump in configs/nvidia-master.yaml for dsr1-fp8-h200-sglang (v0.5.12-cu130 to v0.5.19-cu130), confirmed it now matches the sibling dsr1-fp8-h200-sglang-mtp entry which already used v0.5.19-cu130. Verified the perf-changelog.yaml addition is appended only at the physical end of the file with existing content untouched, and the new entry's config-key, description, and pr-link are well-formed and match the PR.
Extended reasoning...
Overview
This PR touches exactly two files: configs/nvidia-master.yaml (bumping the image field of the dsr1-fp8-h200-sglang recipe from lmsysorg/sglang:v0.5.12-cu130 to lmsysorg/sglang:v0.5.19-cu130) and perf-changelog.yaml (appending one new changelog entry documenting that bump). No other fields in the recipe (model, model-prefix, runner, precision, framework, multinode, scenarios/search-space) were changed, and the diff confirms this matches exactly what the PR description claims.
Security risks
None. This is a version string change to a container image reference in a YAML config, plus an append-only changelog entry. No code execution paths, credentials, auth, or permission logic are touched.
Level of scrutiny
Low. This is a mechanical, single-line image bump of the kind the repo's own conventions (per AGENTS.md/CONTRIBUTING.md as summarized in the review scope) treat as routine, provided the changelog is updated correctly and sibling recipes stay consistent. Both conditions are verified directly from the file contents: the sibling dsr1-fp8-h200-sglang-mtp recipe already uses v0.5.19-cu130 (so this brings the pair in line), and the changelog entry is appended cleanly at end-of-file without altering any prior bytes.
Other factors
No CODEOWNERS-restricted or security-sensitive paths are involved. The changelog's append-only invariant (new entries only at the tail, no reformatting of existing entries) is respected, which is the main structural risk for this file type. No test suite runs are needed beyond what a YAML/config-key validator would already catch, and the change is small and self-contained enough that a human review would only be duplicating this same mechanical check.
Update the
dsr1-fp8-h200-sglangmaster image fromlmsysorg/sglang:v0.5.12-cu130to the current SGLang releaselmsysorg/sglang:v0.5.19-cu130(Docker Hub index digestsha256:d6e7288627be8b02be88e4bba38e73f6d50e2826869f753c13a4c4385ab3eda9, build commit0bcd822). Model, TP8 topology, 8k1k workload, concurrency grid, launch flags and evals are unchanged.Baseline
lmsysorg/sglang:v0.5.12-cu130(build commit127b9e3)random-range-ratiodataset, concurrency 4 / 8 / 16 / 32 / 64aa2df953); the same curve is still the latest published data for this family as of 2026-09-11/api/v1/workflow-info?date=2026-05-17,/api/v1/benchmarks?model=DeepSeek-R1-0528&date=2026-05-17&exact=true,/api/v1/evaluations?model=DeepSeek-R1-0528&date=2026-05-17&exact=trueem_strict0.9583 /em_flexible0.9606 (ID 6394); concurrency 64em_strict0.9583 /em_flexible0.9621 (ID 6395). The published eval rows carrydisagg=truewhile the benchmark rows carrydisagg=falsefor the same run; treated as an identity-metadata quirk, not a different deployment.将
dsr1-fp8-h200-sglang的主配置镜像从lmsysorg/sglang:v0.5.12-cu130更新至当前 SGLang 发行版lmsysorg/sglang:v0.5.19-cu130(Docker Hub 索引摘要sha256:d6e7288627be8b02be88e4bba38e73f6d50e2826869f753c13a4c4385ab3eda9,构建提交0bcd822)。模型、TP8 拓扑、8k1k 工作负载、并发网格、启动参数与评测均保持不变。基线
lmsysorg/sglang:v0.5.12-cu130(构建提交127b9e3)random-range-ratio数据集,并发 4 / 8 / 16 / 32 / 64aa2df953);截至 2026-09-11,该曲线仍是本家族最新的已发布数据/api/v1/workflow-info?date=2026-05-17、/api/v1/benchmarks?model=DeepSeek-R1-0528&date=2026-05-17&exact=true、/api/v1/evaluations?model=DeepSeek-R1-0528&date=2026-05-17&exact=trueem_strict0.9583 /em_flexible0.9606(ID 6394);并发 64em_strict0.9583 /em_flexible0.9621(ID 6395)。已发布的评测行标记为disagg=true,而同一运行的基准行为disagg=false;视为身份元数据的差异,而非不同的部署。🤖 Generated with Claude Code
Note
Low Risk
Config-only Docker image pin and changelog; no runtime code, auth, or workload definition changes.
Overview
Bumps the
dsr1-fp8-h200-sglangmaster benchmark config fromlmsysorg/sglang:v0.5.12-cu130tolmsysorg/sglang:v0.5.19-cu130. DeepSeek-R1-0528 on H200 (FP8, SGLang), TP8 topology, 8k/1k scenario, concurrency sweep, launch flags, and evals are unchanged—only the container image tag moves forward.Adds a matching
perf-changelog.yamlentry fordsr1-fp8-h200-sglangdocumenting the image update (PR #3010).Reviewed by Cursor Bugbot for commit f207db0. Bugbot is set up for automated code reviews on this repo. Configure here.